Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart tool: warn about Dart 3 only allowing sound null safety #49924

Closed
mit-mit opened this issue Sep 8, 2022 · 2 comments
Closed

dart tool: warn about Dart 3 only allowing sound null safety #49924

mit-mit opened this issue Sep 8, 2022 · 2 comments
Assignees
@mit-mit
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool.

Comments

@mit-mit
Copy link
Member

mit-mit commented Sep 8, 2022

In Dart 3 only sound null safety will be allowed.

The dart tool already prints a warning in the compile command when using unsound or no null safety, but we should update to provide more details, and to link to the dart.dev null safety page for more details.

We discussed also adding a warning message to the run command, but decided against that as adding even Info messages to run can be breaking due to scripts and command line app tests looking at the console output.
@mit-mit mit-mit self-assigned this Sep 8, 2022
@mit-mit mit-mit added the area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. label Sep 8, 2022
@mit-mit mit-mit mentioned this issue Sep 8, 2022
Closed
9 tasks
@mit-mit
Copy link
Member Author

mit-mit commented Sep 8, 2022

CL in https://dart-review.googlesource.com/c/sdk/+/257642

@mit-mit mit-mit mentioned this issue Sep 8, 2022
Closed
11 tasks
@mit-mit
Copy link
Member Author

mit-mit commented Sep 8, 2022

Verified in local build:

Screen Shot 2022-09-08 at 12 21 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mit-mit mit-mit

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mit-mit