strong-mode documentation points to archived repo

[timsneath]

The two google links at:

sdk/pkg/analyzer_cli/lib/src/options.dart

Line 383 in 2c0ba56

help: 'Disable implicit casts in strong mode (https://goo.gl/cTLz40).',

sdk/pkg/analyzer_cli/lib/src/options.dart

Line 389 in 2c0ba56

help: 'Disable implicit dynamic (https://goo.gl/m0UgXD).',

both point to a Markdown doc that was last updated in 2016 and is in an archived / deprecated repo.

It's unclear whether these are still relevant. https://dart.dev/guides/language/analysis-options#enabling-additional-type-checks suggests that implicit-casts is now deprecated; it's not clear whether the same applies to implicit-dynamic or not. I'm unclear whether they should still be turned on?

[bwilkerson]

@srawlins For status of the options.

I will point out that the analyzer_cli package contains the implementation of the dartanalyzer command, which itself is deprecated and will at some point be removed. I don't know whether that impacts the importance of dealing with the help documentation.

[parlough]

I do believe these options are now fully covered (and more) by the strict-casts, strict-inference, and strict-raw-types language modes. I don't think they are exposed through the old cli though.

analyzer:
  language:
    strict-casts: true
    strict-inference: true
    strict-raw-types: true

Side note, could we somehow deprecate the strong-mode options in analysis_options.yaml and direct users to the new language modes?

[bwilkerson]

Yes, we can, and probably should, create diagnostic for those cases. We already have one for strong-mode: true, which we believed to be the more common case.

[parlough]

I'm going to close this in favor of #50679 which tracks removing these modes, since the old analyzer_cli referenced here is no longer used.

https://dart.dev/tools/analysis#enabling-additional-type-checks has been updated to document the newer language modes, and previously indicated the deprecated state of the old modes.