Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support assert in initializers in the analyzer #31634

Closed
bwilkerson opened this issue Dec 13, 2017 · 3 comments
Closed

Support assert in initializers in the analyzer #31634

bwilkerson opened this issue Dec 13, 2017 · 3 comments
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@bwilkerson
Copy link
Member

The full syntax should already be supported, but not all error messages are being generated. Start by determining which error messages need to be generated and then implement them.

There are also potential implications for constant evaluation that need to be looked at.

@bwilkerson bwilkerson added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 13, 2017
@scheglov scheglov self-assigned this Dec 14, 2017
@scheglov
Copy link
Contributor

@scheglov scheglov removed their assignment Dec 14, 2017
@bwilkerson bwilkerson self-assigned this Dec 14, 2017
@bwilkerson
Copy link
Member Author

Two CL's in flight:
add evaluation support: https://dart-review.googlesource.com/c/sdk/+/32100.
add check for non-bool expressions: https://dart-review.googlesource.com/c/sdk/+/31963.

@devoncarew devoncarew added this to the 2.0-alpha2 milestone Jan 26, 2018
@bwilkerson
Copy link
Member Author

Both have now landed, so I believe this arc of work is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants