Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: hide the script snapshot version errors when running dart script #22308

Closed
sethladd opened this issue Feb 6, 2015 · 2 comments
Closed
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

sethladd commented Feb 6, 2015

Hi,

Usability/aesthetics request. When changing your Dart version, and then running a script from pub's bin cache, we'll see this:

sethladd@sethladd-macbookair ~/tmp/angulartest $ stagehand ubersimplewebapp
Wrong script snapshot version, expected '9b71a36fb6f35a4247b4baef055b2626' found '836a274342f7f88d6b5a9bb59b2649a9'
Wrong script snapshot version, expected '9b71a36fb6f35a4247b4baef055b2626' found '836a274342f7f88d6b5a9bb59b2649a9'
Creating ubersimplewebapp application 'angulartest':
  /Users/sethladd/tmp/angulartest/.gitignore
  /Users/sethladd/tmp/angulartest/CHANGELOG.md
  /Users/sethladd/tmp/angulartest/LICENSE
  /Users/sethladd/tmp/angulartest/README.md
  /Users/sethladd/tmp/angulartest/pubspec.yaml
  /Users/sethladd/tmp/angulartest/web/index.html
  /Users/sethladd/tmp/angulartest/web/main.dart
  /Users/sethladd/tmp/angulartest/web/styles/main.css
8 files written.

--> to provision required packages, run 'pub get'
sethladd@sethladd-macbookair ~/tmp/angulartest $

Notice the two "wrong script snapshot version" messages. Two messages is a bit weird, and the message itself isn't that useful to an end user.

Could we display something more user friendly? Suggestion: "Dart VM version changed, generating new snapshot for app"

Thanks!

@nex3
Copy link
Member

nex3 commented Feb 6, 2015

I'd dearly love to get rid of this message, but unfortunately the VM provides no way to control it (issue #20784) and no alternate way to check if a snapshot is up-to-date (issue #20802).

In theory we could try to filter the executable's stdout for this specific message, but in practice doing this in both the binstub scripts and pub itself a way that doesn't cause further problems is nearly impossible.


Marked this as being blocked by #20784, #20802.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#1244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants