Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartC release failure on co19/LibTest/core/String/contains/String/contains/A03/t01 #1317

Closed
scheglov opened this issue Jan 24, 2012 · 2 comments
Labels
closed-duplicate Closed in favor of an existing report

Comments

@scheglov
Copy link
Contributor

May be "if" optimization in "catch" is incorrect.

main() {
  try {
    "string".contains(null, 0);
    Expect.fail("NullPointerException is expected");
  } catch(NullPointerException e) {}
}

==== Unoptimized method
function unnamed61589a$main$member(){
  var e_0, tmp$0;
  try {
    'string'.contains$named(2, $noargs, $Dart$Null, 0);
    Expect$Dart.fail$member('NullPointerException is expected');
  }
   catch (e) {
    e = $transformBrowserException(e);
    if (!!(tmp$0 = e , tmp$0 != null && tmp$0.$implements$NullPointerException$Dart)) {
      e_0 = e;
    }
     else
      throw e;
  }
}
================

==== Optimized method
function(){a(b)});La();v=c}})(function(){var a;try{oa(Nb()).W(0,q);var b="Expect.fail('"+O("NullPointerException is expected")+"')",c=new pc(b);c.g=E("Oa",qc,null,void 0);i(c)}catch(d){if(d=fa(d),!(a=d,a!=null&&a.Aa))throw d;}}
================

=== releaseia32 dartc co19/LibTest/core/String/contains/String/contains/A03/t01 ===
Path: co19/LibTest/core/String/contains/String/contains/A03/t01
/tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31: [object Object]
qc,null,void 0);i(c)}catch(d){if(d=fa(d),!(a=d,a!=null&&a.Aa))throw d;}},this.
                                                                    ^
[object Object]
    at i (/tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:2:124)
    at /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:3025
    at /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:2865
    at Pa (/tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:7:438)
    at Xa (/tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:9:80)
    at Ya (/tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:9:410)
    at La (/tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:10:77)
    at /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:2872
    at /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:2882
Execution failed.
Mapped stack trace:
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:2:124 (i)
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:3025
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:2865
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:7:438 (Pa)
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:9:80 (Xa)
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:9:410 (Ya)
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:10:77 (La)
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:2872
    at UNMAPPED: /tmp/dart_tests_co19_src_LibTest_core_String_contains_String_contains_A03_t01.dart9201805734861164504.js:31:2882

@scheglov
Copy link
Contributor Author

This test was marked as failing.
https://chromiumcodereview.appspot.com/9284027/

@DartBot
Copy link

DartBot commented Jan 24, 2012

This comment was originally written by [email protected]


Added Duplicate label.
Marked as being merged into #219.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Development

No branches or pull requests

2 participants