finally clause is sometimes executed twice.

[floitschG]

The finally block is, under special circumstances, executed twice.

The following code (extracted from language/throw8_test.dart) shows some conditions:
===
 try {
    try { // <==== requires nested try.
      return 499; // <=== must return something.
    } catch (e, st) {
      rethrow;
    }
  } finally {
    finallyExecutionCount++; // <== should not be invoked twice.
    throw "quit finally with throw"; // <=== must throw.
  }
===

I'm leaving the priority unassigned, but please consider making this a high priority bug, since it's extremely hard to debug.

[floitschG]

Issue #11969 has been merged into this issue.

[floitschG]

Issue #12195 has been merged into this issue.

---

cc @justinfagnani.

[fsc8000]

I'll take a look. There is a bug in the VM compiler.

A similar reproduction with two nested try-finally blocks:

  try {
    try { // <==== requires nested try.
      return 499; // <=== must return something.
    } finally {
      print("inner finally");
    }
  } finally {
    finallyExecutionCount++; // <== should not be invoked twice.
    throw "quit finally with throw"; // <=== must throw.
  }

---

Set owner to @fsc8000.
Added Accepted label.

[fsc8000]

Removed Priority-Unassigned label.
Added Priority-Uigne label.

[fsc8000]

Removed Priority-Uigne label.
Added Priority-High label.

[fsc8000]

Fixed in r25767.

---

Added Fixed label.