Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart pub publish incorrectly warns about a checked-in symlink folder being ignored #3789

Open
evanweible-wf opened this issue Feb 14, 2023 · 3 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@evanweible-wf
Copy link
Contributor

  • Dart SDK Version (dart --version): 2.19.2 (stable) (Tue Feb 7 18:37:17 2023 +0000) on "macos_x64"

We have a project that exhibits this issue and it seems to be related to the fact that we have a folder symlink as one of our test fixtures.

This project includes a .pubignore file that should be ignoring the entirety of test/. That appears to be working for everything except the above folder symlink, which shows up as a warning from dart pub publish --dry-run:

$ dart pub publish --dry-run
Package validation found the following potential issues:
* 1 checked-in file is ignored by a `.gitignore`.
  Previous versions of Pub would include those in the published package.
  
  Consider adjusting your `.gitignore` files to not ignore those files, and if you do not wish to
  publish these files use `.pubignore`. See also dart.dev/go/pubignore
  
  Files that are checked in while gitignored:
  
  test/tools/fixtures/format/globs/links/lib-link
@mraleph mraleph transferred this issue from dart-lang/sdk Feb 14, 2023
@mraleph
Copy link
Member

mraleph commented Feb 14, 2023

/cc @sigurdm

@sigurdm sigurdm added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Feb 15, 2023
@Nialixus
Copy link

In my case, this warning disappeared after I pushed the commit to the repository.

@joecotton-wk
Copy link

joecotton-wk commented Apr 3, 2024

@sigurdm Has any progress been made on this? We have another project that is experiencing a very similar issue (link). The JSON-Schema-Test-Suite is copy of https://github.com/json-schema-org/JSON-Schema-Test-Suite, and is not excluded in the .gitignore in any way.

And, unlike what @Nialixus experienced, the warning has not disappeared after pushing to the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants