Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pub serve to work without a packages/ directory #1331

Closed
sethladd opened this issue Sep 3, 2015 · 4 comments
Closed

Enable pub serve to work without a packages/ directory #1331

sethladd opened this issue Sep 3, 2015 · 4 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

sethladd commented Sep 3, 2015

We believe that if the packages/ directory of symlinks was removed, that pub serve would stop working.

This is a tracking bug to ensure that pub serve works, even if there isn't a packages/ directory.

(this issue is part of "Eliminating symlinks, phase two" dart-lang/sdk#24112)

@sethladd sethladd added the type-enhancement A request for a change that isn't a bug label Sep 3, 2015
@nex3
Copy link
Member

nex3 commented Sep 8, 2015

We believe that if the packages/ directory of symlinks was removed, that pub serve would stop working.

I'm not sure where this is coming from (probably me saying something confusing), but pub serve doesn't rely on symlinks at all, and never has. The server automatically serves requests including /packages/ based on its internal knowledge of the package graph, without any reference to a packages/ directory that may or may not exist on the filesystem.

@nex3 nex3 closed this as completed Sep 8, 2015
@sethladd
Copy link
Contributor Author

sethladd commented Sep 9, 2015

Ah, thanks for the clarification! Great to know.

(if there are specific cases where pub will break if there isn't a packages/ dir, can you please point me to those issues so we can track? Thanks!)

@nex3
Copy link
Member

nex3 commented Sep 9, 2015

Other than pub run (which has since been updated), pub existed purely as a generator of the packages/ directory, not as a consumer, so there aren't any cases where it itself will break if the directory stops being generated. There are plenty of cases where users of pub could break, but that's already being (more or less) tracked by e.g. dart-lang/test#327.

@sethladd
Copy link
Contributor Author

Thanks @nex3 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants