This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
Fix parsing of inline code blocks with multiple backticks #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed internal check is fine; we have a broken patch file. |
munificent
approved these changes
Sep 11, 2019
| bool canParse(BlockParser parser) { | ||
| var match = pattern.firstMatch(parser.current); | ||
| if (match == null) return false; | ||
| final codeFence = match.group(1); |
There was a problem hiding this comment.
Use var here and below or final above.
lib/src/block_parser.dart
Outdated
| // | ||
| // > If the info string comes after a backtick fence, it may not contain | ||
| // > any backtick characters. | ||
| if (codeFence.codeUnitAt(0) == $backquote && |
There was a problem hiding this comment.
How about:
return codeFence.codeUnitAt(0) != $backquote ||
!infoString.codeUnits.contains($backquote));
srawlins
commented
Sep 12, 2019
| bool canParse(BlockParser parser) { | ||
| var match = pattern.firstMatch(parser.current); | ||
| if (match == null) return false; | ||
| final codeFence = match.group(1); |
lib/src/block_parser.dart
Outdated
| // | ||
| // > If the info string comes after a backtick fence, it may not contain | ||
| // > any backtick characters. | ||
| if (codeFence.codeUnitAt(0) == $backquote && |
|
Land it! |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
…ve/markdown#260) Fix parsing of inline code blocks with multiple backticks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/tools#1406