Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape HTML attribute for fenced code blocks, in the info string; 2.0.3 #244

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

srawlins
Copy link
Member

No description provided.

@srawlins srawlins requested a review from kevmoo April 16, 2019 17:24
@kevmoo
Copy link
Member

kevmoo commented Apr 16, 2019

Looks like you need to re-run the common mark and gfm stats

@srawlins
Copy link
Member Author

Bumped.

The spec is #311. Here's BabelMark showing that most renderers keep the entity codes as they are, while CommonMark literally changes them to their Unicode character.

I think we should just let this regression in... I'm not sure how to not escape the &. From HtmlEscapeMode's docs:

All modes require escaping of & (ampersand) characters, and may enable escaping of more characters.

Womp womp.

@srawlins srawlins merged commit 9fcb831 into dart-lang:master Apr 16, 2019
@srawlins srawlins deleted the escape branch April 16, 2019 17:44
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
….3 (dart-lang/markdown#244)

Escape HTML attribute for fenced code blocks, in the info string; 2.0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants