Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeSyntax to respect encodeHtml flag #239

Merged
merged 6 commits into from
Mar 26, 2019

Conversation

sldsrg
Copy link
Contributor

@sldsrg sldsrg commented Mar 25, 2019

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sldsrg
Copy link
Contributor Author

sldsrg commented Mar 25, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sldsrg ! Seems like a long-standing obvious bug, but I think encodeHtml: false is not used much (introduced for Flutter, I believe). Your reading of encodeHtml: false is the correct one.

@srawlins srawlins merged commit 0d175aa into dart-lang:master Mar 26, 2019
@sldsrg sldsrg deleted the encode-html branch March 27, 2019 04:45
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
…markdown#239)

Fix codeSyntax and BlockParser to respect encodeHtml flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants