From 6a7db8a8a3f31fed7ad29456dd7ea78f12123fe4 Mon Sep 17 00:00:00 2001 From: Alex Li Date: Wed, 10 Jan 2024 10:32:19 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=9A=20Fix=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/cronet.yml | 9 +++++++-- pkgs/cronet_http/android/build.gradle | 1 - pkgs/cronet_http/example/android/app/build.gradle | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cronet.yml b/.github/workflows/cronet.yml index 80d55ee660..74571fb904 100644 --- a/.github/workflows/cronet.yml +++ b/.github/workflows/cronet.yml @@ -58,7 +58,12 @@ jobs: uses: reactivecircus/android-emulator-runner@v2 if: always() && steps.install.outcome == 'success' with: - api-level: 28 - target: ${{ matrix.package == 'cronet_http_embedded' && 'google_apis' || 'playstore' }} + # api-level/minSdkVersion should be help in sync in: + # - .github/workflows/cronet.yml + # - pkgs/cronet_http/android/build.gradle + # - pkgs/cronet_http/example/android/app/build.gradle + api-level: 21 + arch: x86_64 + target: ${{ matrix.package == 'cronet_http_embedded' && 'default' || 'google_apis' }} profile: pixel script: cd 'pkgs/${{ matrix.package }}/example' && flutter test --timeout=1200s integration_test/ diff --git a/pkgs/cronet_http/android/build.gradle b/pkgs/cronet_http/android/build.gradle index 00248975d2..af945d9d8b 100644 --- a/pkgs/cronet_http/android/build.gradle +++ b/pkgs/cronet_http/android/build.gradle @@ -65,6 +65,5 @@ android { } dependencies { - implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" implementation "com.google.android.gms:play-services-cronet:18.0.1" } diff --git a/pkgs/cronet_http/example/android/app/build.gradle b/pkgs/cronet_http/example/android/app/build.gradle index b8e0a66a46..34673724a5 100644 --- a/pkgs/cronet_http/example/android/app/build.gradle +++ b/pkgs/cronet_http/example/android/app/build.gradle @@ -68,7 +68,7 @@ flutter { } dependencies { - implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" + implementation(platform("org.jetbrains.kotlin:kotlin-bom:1.8.0")) // ""com.google.android.gms:play-services-cronet" is only present so that // `jnigen` will work. Applications should not include this line. implementation "com.google.android.gms:play-services-cronet:18.0.1"