From b9b01b55f6af43f49891c4a56dc327445688b118 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 5 Sep 2023 16:47:28 +0200 Subject: [PATCH 1/4] test workflow --- .github/workflows/publish_internal.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish_internal.yaml b/.github/workflows/publish_internal.yaml index 82b07bf6..9aa440bd 100644 --- a/.github/workflows/publish_internal.yaml +++ b/.github/workflows/publish_internal.yaml @@ -12,6 +12,9 @@ on: push: tags: [ '[A-z]+-v[0-9]+.[0-9]+.[0-9]+' ] +env: + use-flutter: false + jobs: publish: if: github.repository_owner == 'dart-lang' @@ -37,8 +40,8 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} ISSUE_NUMBER: ${{ github.event.number }} PR_LABELS: "${{ join(github.event.pull_request.labels.*.name) }}" - run: dart pkgs/firehose/bin/firehose.dart --validate + run: dart pub global run firehose --validate ${{ env.use-flutter && '--use-flutter' || '--no-use-flutter' }} - name: Publish tagged package if: ${{ github.event_name == 'push' }} - run: dart pkgs/firehose/bin/firehose.dart --publish + run: dart pkgs/firehose/bin/firehose.dart --publish ${{ env.use-flutter && '--use-flutter' || '--no-use-flutter' }} From c7565c9cf43ef6a27c56713196bb999a3e58fd43 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 5 Sep 2023 16:50:16 +0200 Subject: [PATCH 2/4] Use Json --- .github/workflows/publish_internal.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish_internal.yaml b/.github/workflows/publish_internal.yaml index 9aa440bd..e46c78cd 100644 --- a/.github/workflows/publish_internal.yaml +++ b/.github/workflows/publish_internal.yaml @@ -40,8 +40,8 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} ISSUE_NUMBER: ${{ github.event.number }} PR_LABELS: "${{ join(github.event.pull_request.labels.*.name) }}" - run: dart pub global run firehose --validate ${{ env.use-flutter && '--use-flutter' || '--no-use-flutter' }} + run: dart pub global run firehose --validate ${{ fromJSON('{"true":"--use-flutter","false":"--no-use-flutter"}')[env.use-flutter] }} - name: Publish tagged package if: ${{ github.event_name == 'push' }} - run: dart pkgs/firehose/bin/firehose.dart --publish ${{ env.use-flutter && '--use-flutter' || '--no-use-flutter' }} + run: dart pkgs/firehose/bin/firehose.dart --publish ${{ fromJSON('{"true":"--use-flutter","false":"--no-use-flutter"}')[env.use-flutter] }} From c868dc6662f0d965eb765ad1f637e8854666226c Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 5 Sep 2023 16:52:15 +0200 Subject: [PATCH 3/4] Refer to local --- .github/workflows/publish_internal.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish_internal.yaml b/.github/workflows/publish_internal.yaml index e46c78cd..c34d8bc8 100644 --- a/.github/workflows/publish_internal.yaml +++ b/.github/workflows/publish_internal.yaml @@ -40,7 +40,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} ISSUE_NUMBER: ${{ github.event.number }} PR_LABELS: "${{ join(github.event.pull_request.labels.*.name) }}" - run: dart pub global run firehose --validate ${{ fromJSON('{"true":"--use-flutter","false":"--no-use-flutter"}')[env.use-flutter] }} + run: dart pkgs/firehose/bin/firehose.dart --validate ${{ fromJSON('{"true":"--use-flutter","false":"--no-use-flutter"}')[env.use-flutter] }} - name: Publish tagged package if: ${{ github.event_name == 'push' }} From e684e40e4f6856e370e9048e329b0b72455e195f Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 5 Sep 2023 16:53:40 +0200 Subject: [PATCH 4/4] Fix boolean check --- .github/workflows/publish.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index fcec958d..8ddc2cb1 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -94,7 +94,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} ISSUE_NUMBER: ${{ github.event.number }} PR_LABELS: "${{ join(github.event.pull_request.labels.*.name) }}" - run: dart pub global run firehose --validate ${{ inputs.use-flutter && '--use-flutter' || '--no-use-flutter' }} + run: dart pub global run firehose --validate ${{ fromJSON('{"true":"--use-flutter","false":"--no-use-flutter"}')[inputs.use-flutter] }} publish: if: ${{ github.event_name == 'push' }} @@ -124,4 +124,4 @@ jobs: run: dart pub global activate firehose - name: Publish packages - run: dart pub global run firehose --publish ${{ inputs.use-flutter && '--use-flutter' || '--no-use-flutter' }} + run: dart pub global run firehose --publish ${{ fromJSON('{"true":"--use-flutter","false":"--no-use-flutter"}')[inputs.use-flutter] }}