Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow firehose to write comments to PRs from forks #156

Closed
devoncarew opened this issue Aug 30, 2023 · 1 comment · Fixed by #165
Closed

allow firehose to write comments to PRs from forks #156

devoncarew opened this issue Aug 30, 2023 · 1 comment · Fixed by #165
Labels
package:firehose

Comments

@devoncarew
Copy link
Member

I believe there is some permissions work we can do to allow firehose to write comments to PRs from forks (currently it can write the workflow summary but not a comment to the PR; the PR comment is much more visible to users).

cc @mosuem
@mosuem
Copy link
Member

mosuem commented Aug 31, 2023

This would basically be achieved by uploading the comment as an artifact, triggering a second workflow, downloading the artifact there and publishing it as a comment.

@parlough parlough mentioned this issue Aug 31, 2023
Merged
@mosuem mosuem mentioned this issue Sep 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:firehose
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write comments on forks for firehose dart-lang/ecosystem
2 participants
@devoncarew @mosuem