Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate public exports in lib/dartdoc.dart. #3589

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Deprecate public exports in lib/dartdoc.dart. #3589

merged 1 commit into from
Nov 30, 2023

Conversation

kallentu
Copy link
Member

Public exports deprecated for 8.0.1 bump eventually and will be fully removed in 9.0.0.

  • Updated the tests to avoid using the import.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kallentu kallentu requested a review from srawlins November 29, 2023 23:38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should deprecate this file too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the classes in the file?
We should eventually just move them to src/dartdoc_options.dart or something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this one first and I can get another commit going for options.dart :D

lib/dartdoc.dart Show resolved Hide resolved
@kallentu kallentu merged commit 0499c4e into main Nov 30, 2023
11 checks passed
@kallentu kallentu deleted the dep-public branch November 30, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants