Improve display text for libraries

[srawlins]

Fixes #1658 and fixes #1000.

The changes in this PR do not ever print the full import URI (like package:googleapis/admob/v1.dart) or even the import path with the .dart extension (like admob/v1.dart), except in the breadcrumb. Mainly this PR uses the basename of the library with its directory path after lib/ (like admob/v1). Here are some screenshots:

---

---

---

---

---

---

Additionally:

• Make Library.prefixToLibrary private.
• Refactor Library.dirName to just inline all of its helper methods. I think it is much more readable this way.
• Remove Library.nameFromPath (as part of the above).

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[devoncarew]

For my 0.02, I do think it's useful to show the file extension (admob/v1.dart instead of admob/v1), even at the expense of some brevity. It helps the user know what they're looking at w/o having to think about it, and will be familiar with what they'd import or what they'd see in their IDE.

[srawlins]

CC @kevmoo @goderbauer

[kevmoo]

For my 0.02, I do think it's useful to show the file extension (admob/v1.dart instead of admob/v1), even at the expense of some brevity. It helps the user know what they're looking at w/o having to think about it, and will be familiar with what they'd import or what they'd see in their IDE.

I'd actually argue LEAVE the .dart out and ship that way (maybe have it in a tooltip) and see if there are complains!

[srawlins]

@goderbauer I found a few differences in how this shows api.flutter.dev; almost zero libraries are located deeper than lib/ so this PR changes very little for Flutter. But the material_color_utilities package has some:

BEFORE

---

AFTER

There may be some misconceptions about src/ directories in that package's layout.

[srawlins]

For now, there were more recommendations to leave the .dart off of library names, and I agree it kind of noises up the left sidebar for api.flutter.dev.

And yes, I really like the tooltip idea. I'd like to land that as well, separately.

[goderbauer]

There may be some misconceptions about src/ directories in that package's layout.

I would agree with that. Given the current layout, dartdoc's output seems reasonable, though. I'll see if we can fix up the layout, but that shouldn't block this work here.

[srawlins]

Hi @kallentu , as part of learning the code here, you could participate in code review for this PR. You can read over the two issues that are fixed by this PR and ask me any questions about the code.