Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display an error message instead of crashing on wrong data type in dartdoc_options.yaml #3372

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Display an error message instead of crashing on wrong data type in dartdoc_options.yaml #3372

merged 1 commit into from
Mar 23, 2023

Conversation

jcollins-g
Copy link
Contributor

Fixes #3365.

New error message:

Documenting input_country...

dartdoc 6.2.0 (/Users/jcollins/dart/dartdoc/bin/dartdoc.dart) failed: Error in dartdoc_options.yaml, dartdoc.include: expecting a list of Strings, got `flutter_input`.

@jcollins-g jcollins-g mentioned this pull request Mar 23, 2023
Closed
@jcollins-g jcollins-g requested a review from srawlins March 23, 2023 21:06
srawlins
srawlins approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@jcollins-g jcollins-g merged commit 15d1e25 into dart-lang:master Mar 23, 2023
@jcollins-g jcollins-g deleted the bug-3365 branch March 23, 2023 21:39
@jcollins-g jcollins-g mentioned this pull request Mar 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type 'Null' is not a subtype of type 'List<String>' in type cast
2 participants
@jcollins-g @srawlins