Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In "implementers" list, include extension type implementers along with classes and mixins #3656

Closed
kevmoo opened this issue Feb 12, 2024 · 7 comments · Fixed by #3658 or #3682
Closed
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2024

See TypeData - https://api.dart.dev/main/4ddc4a9e8d1a13aa50bac280669e4334e39a0b57/dart-typed_data/TypedData-class.html

You see all of the implementers.

See JSTypedArray - https://api.dart.dev/main/4ddc4a9e8d1a13aa50bac280669e4334e39a0b57/dart-js_interop/JSTypedArray-extension-type.html

/// The Javascript `Int8Array`.
@JS('Int8Array')
extension type JSInt8Array._(JSInt8ArrayRepType _jsInt8Array)
    implements JSTypedArray {}

I'd expect to see implementers, too!

@srawlins
Copy link
Member

Thanks for the report, Kevin!

@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 13, 2024
@srawlins
Copy link
Member

BTW we do have tests that this works so... something fishy :D

@srawlins
Copy link
Member

Wait no, you lost me. Why do you expect to see implementers on the page for extension type JSInt8Array? Who implements JSInt8Array? Is that even legal?

@parlough
Copy link
Member

parlough commented Feb 13, 2024

I think Kevin means the page for JSTypedArray should show that JSInt8Array implements it.

I still think it's a bit confusing that implements is reused here, so perhaps some further distinguishing makes sense in the UI, not sure?

@srawlins
Copy link
Member

OK. We can add that feature.

@srawlins srawlins changed the title Show extension type implementers just like normal implements In "implementers" list, include extension type implementers along with classes and mixins Feb 13, 2024
@srawlins srawlins self-assigned this Feb 15, 2024
@kevmoo
Copy link
Member Author

kevmoo commented Feb 21, 2024

@kevmoo kevmoo reopened this Feb 21, 2024
@srawlins
Copy link
Member

Ah, I think it's that JSTypedArray is also an extension type. Can fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
3 participants