Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional function/method parameters incorrectly formatted #2059

Closed
cbracken opened this issue Nov 6, 2019 · 1 comment · Fixed by #2075
Closed

Optional function/method parameters incorrectly formatted #2059

cbracken opened this issue Nov 6, 2019 · 1 comment · Fixed by #2075
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@cbracken
Copy link
Member

cbracken commented Nov 6, 2019

Originally filed by @jeffque as google/quiver-dart#575:

The documentation for the function quiver.core.firstNonNull is being displayed like this:

firstNonNull(dynamic o1, [ dynamic o2, [ dynamic o3 dynamic o4 ])

with an extra square brakets between o1 and o2. I also noted a lack of comma separating o3 and o4 now. Maybe related?

It can be found at least here and here

But, seeing the code, I would expect something like this

firstNonNull(dynamic o1, dynamic o2, [ dynamic o3, dynamic o4 ])

or this:

firstNonNull(o1, o2, [ o3, o4 ])
@cbracken cbracken added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Nov 6, 2019
@jcollins-g jcollins-g added the P2 A bug or feature request we're likely to work on label Nov 7, 2019
@cbracken
Copy link
Member Author

cbracken commented Nov 19, 2019

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants