Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter with Dart 2.1 mixins does not display mixins separately #1785

Closed
jcollins-g opened this issue Oct 5, 2018 · 2 comments · Fixed by #1786
Closed

Flutter with Dart 2.1 mixins does not display mixins separately #1785

jcollins-g opened this issue Oct 5, 2018 · 2 comments · Fixed by #1786
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@jcollins-g
Copy link
Contributor

cc @yjbanov

While testing flutter/flutter#22435 with 0.23.0, discovered that Mixins are still listed with Classes somehow in sidebars and in the library page.

@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures customer-flutter Issues originating from important to Flutter labels Oct 5, 2018
@jcollins-g
Copy link
Contributor Author

Double-checked and in at least some cases we do display mixins in the right section, so now I need to narrow down how the mixins in flutter/flutter#22435 differ from my test cases.

@jcollins-g
Copy link
Contributor Author

Dartdoc was still using type checks on MixinElementImpl in some places to detect mixins, but since with heavy reexporting ClassElementHandles can be returned from _exportedNamespace (and Flutter makes use of reexporting a great deal), we were hitting assertion cases when they were used inside flutter.

Fix coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant