-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dartdoc needs to be migrated to the new analysis driver #1586
Comments
also cc'ing @pq, as he has done the migration for the linter, so could provide pointers / links to PRs. |
Situation is better for dartdoc nowadays -- there's only one point at which we grab AnalysisContexts from the analyzer, which is here: Line 4853 in 7d3e01f
We can move dartdoc by porting over this small section to whatever can give us analyzer data. |
Cool! FWIW, here's the relevant PR for the linter migration: dart-archive/linter#754. Happy to walk you through it whenever. |
This will also enable interpretation of analysis options files. |
I started on this yesterday and got dartdoc mostly functioning in the way that it does now (a PR to come soon). However, it turns out that we can't quite get analysis options file interpretation going as quickly. The architecture of the analyzer requires there to be one Talked with @bwilkerson and creating something that creates This means that for #1595 we'll need to hack around the errors yet again until we can get the proper API from the analyzer (or, alternatively, give up and implement it ourselves within dartdoc). In the meantime, this issue will be redefined as simply get us out of using the AnalysisContext objects. |
The Dart 2.0 features mentioned in dart-lang/sdk#31640 are going to be implemented using the new analysis driver; they aren't guaranteed to be backported to the old analyzer task model. So in order to ensure that Dartdoc is Dart 2.0 compliant we will need to change Dartdoc to make use of the new analysis driver.
We will probably need assistance from @bwilkerson and @scheglov to determine the proper analyzer entry points for Dartdoc to use.
The text was updated successfully, but these errors were encountered: