Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrollableBlock isn't linked from Block API docs for Flutter #1238

Closed
sethladd opened this issue Aug 30, 2016 · 5 comments
Closed

ScrollableBlock isn't linked from Block API docs for Flutter #1238

sethladd opened this issue Aug 30, 2016 · 5 comments
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sethladd
Copy link
Contributor

sethladd commented Aug 30, 2016 •
edited
Loading

From https://docs.flutter.io/flutter/material/Block-class.html and https://docs.flutter.io/flutter/widgets/Block-class.html

Notice how LazyBlock isn't linked. That dartdoc comment is here: https://github.com/flutter/flutter/blob/c76decb84276486468c90a0c2a90df0b9d4895f2/packages/flutter/lib/src/widgets/scrollable.dart#L946

Can we link to ScrollableBlock from the doc comments in this page?

Thanks!
@sethladd sethladd added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) customer-flutter Issues originating from important to Flutter labels Aug 30, 2016
@sethladd
Copy link
Contributor Author

cc @devoncarew @keertip

@sethladd
Copy link
Contributor Author

Also note that Icon isn't linked from https://docs.flutter.io/flutter/material/Icons-class.html

@devoncarew devoncarew added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Sep 1, 2016
@keertip
Copy link
Collaborator

keertip commented Sep 27, 2016

looks like a dupe asking for #1153

@astashov
Copy link
Contributor

If it's dupe, should it be closed?

@devoncarew
Copy link
Member

Closing as a dupe; @astashov has a PR for #1153 in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sethladd @astashov @devoncarew @keertip