From dd8ed1b27adb4a6bf0cdf3948b2883a427094b5c Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Thu, 19 May 2016 17:27:20 -0700 Subject: [PATCH] comment linter issues --- .analysis_options | 3 +++ lib/src/class.dart | 2 ++ lib/src/error.dart | 1 + lib/vm_service_client.dart | 1 + 4 files changed, 7 insertions(+) create mode 100644 .analysis_options diff --git a/.analysis_options b/.analysis_options new file mode 100644 index 0000000..a87160f --- /dev/null +++ b/.analysis_options @@ -0,0 +1,3 @@ +linter: + rules: + - comment_references diff --git a/lib/src/class.dart b/lib/src/class.dart index ef95c9d..31ea97d 100644 --- a/lib/src/class.dart +++ b/lib/src/class.dart @@ -44,6 +44,8 @@ class VMClassRef implements VMObjectRef { /// Evaluates [expression] in the context of this class. /// + /// -- A LOT of these – need a way to reference types in non-imported libs + /// -- requiring an import just for these would REALLY suck. /// Throws a [VMErrorException] if evaluating the expression throws an error. Future evaluate(String expression) => _scope.evaluate(_id, expression); diff --git a/lib/src/error.dart b/lib/src/error.dart index 4acf5bf..e35b5f4 100644 --- a/lib/src/error.dart +++ b/lib/src/error.dart @@ -113,6 +113,7 @@ class VMErrorKind { /// An internal error. /// + /// --- boo! detecting a link as a reference. Easy to fix? /// These errors should not be exposed—if seen, they should be [reported as /// bugs](https://github.com/dart-lang/sdk/issues/new). static const internalError = const VMErrorKind._("InternalError"); diff --git a/lib/vm_service_client.dart b/lib/vm_service_client.dart index 0e951ab..59661ba 100644 --- a/lib/vm_service_client.dart +++ b/lib/vm_service_client.dart @@ -61,6 +61,7 @@ final _jsonSinkEncoder = new StreamSinkTransformer.fromHandlers( /// /// [service api]: https://github.com/dart-lang/sdk/blob/master/runtime/vm/service/service.md /// +/// --- no clue why `connect` here is an error, but `getVM` is fine. Help? /// Connect to a VM service endpoint using [connect], and use [getVM] to load /// information about the VM itself. ///