Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Revert "feat(urls): support relative CSS / template URLs in components" #1456

Closed
vicb opened this issue Sep 15, 2014 · 4 comments
Closed

Revert "feat(urls): support relative CSS / template URLs in components" #1456

vicb opened this issue Sep 15, 2014 · 4 comments
Labels
type: bug

Comments

@vicb
Copy link
Contributor

vicb commented Sep 15, 2014

I propose that we revert feat(urls): support relative CSS / template URLs in components

because:

We should re-integrate it once all the bugs have been fixed.

Note that the following fixes need to be reverted (chronological order):
@vicb vicb mentioned this issue Sep 15, 2014
Closed
@vicb vicb added the type: bug label Sep 15, 2014
@vicb
Copy link
Contributor Author

vicb commented Sep 17, 2014

@chirayuk in the following code

    HtmlDocument doc = new DomParser().parseFromString(
        "<!doctype html><html><body>$html</body></html>", "text/html");
    if (doc != null) {
      return doc.body;
    }
    // Workaround for Safari (can't parse HTML documents via the DomParser)
    doc = document.implementation.createHtmlDocument("");
    doc.body.setInnerHtml(html, treeSanitizer: _nullTreeSanitizer);
    return doc.body;

would the second part work with all browsers so that we don't have to account for a special case ?
If yes, would it have any drawback ?

@vsavkin vsavkin mentioned this issue Sep 17, 2014
Closed
16 tasks
@vicb
Copy link
Contributor Author

vicb commented Sep 18, 2014

TODO: re-enable IE tests once this gets fixed

@scriptsrc
Copy link

+1

I'm waiting on angulardartui issue 102 which is apparently waiting on angular issue 1415 which is waiting on this issue. Can't wait!

@naomiblack
Copy link
Contributor

Reverting is too aggressive. Let's break this into smaller individual actions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chirayuk @vicb @naomiblack @scriptsrc