Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

DirectiveInjector (todo tracking) #1240

Closed
2 tasks done
vicb opened this issue Jul 17, 2014 · 4 comments
Closed
2 tasks done

DirectiveInjector (todo tracking) #1240

vicb opened this issue Jul 17, 2014 · 4 comments

Comments

@vicb
Copy link
Contributor

vicb commented Jul 17, 2014

  • DirectiveInjector implements DirectiveBinder but bind() args do not match
  • DirectiveInjector maintains a depth but there is no assertion / check for a max depth
@rkirov
Copy link
Contributor

rkirov commented Jul 28, 2014

#1244 adds max depth for DirectiveInjector

@vicb
Copy link
Contributor Author

vicb commented Jul 29, 2014

@rkirov is max depth intended to support detecting circular dependency ? if yes, there should be a unit test.

bind() (1st item no the list) has been fixed in f8bbd35

@rkirov
Copy link
Contributor

rkirov commented Aug 18, 2014

There are two different notions of depth, so I think I got confused.

@vicb
Copy link
Contributor Author

vicb commented Aug 25, 2014

Closing this as defect are solved (or PR pending)

@vicb vicb closed this as completed Aug 25, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants