Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected api endpoint availability #585

Open
teodorescuserban opened this issue Dec 11, 2024 · 1 comment
Open

unexpected api endpoint availability #585

teodorescuserban opened this issue Dec 11, 2024 · 1 comment

Comments

@teodorescuserban
Copy link

I am using souin as caddy module.

I only cache some of the requests. I was very surprised to notice (after a couple of hours of unsuccessful tries) that in certain configurations the souin api endpoint is not available. More precise, if a request to /souin-api/souin is not configured to be cached, the api won't respond.

Like in this Caddyfile example:

{
    cache
}

:80 {

    @somecache path /i-cache-this
    @nocache not path /i-cache-this

    route @somecache {
        cache
        respond "caching."
    }

    route @nocache {
        respond "not caching. and no souin api."    
    }
}

Now, I don't have a sane suggestion. My first instinct would tell me that it would be nice to have the souin-api endpoint liked to the caddy admin port instead. But there are a number of problems with that.

Perhaps the best solution would br to just document that (with a nice example of how to also secure the souin api endpoint from external).

Keep up the good work, @darkweak !

@darkweak
Copy link
Owner

Hey @teodorescuserban I plan to bring this feature in the PR #589.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants