Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Go to 1.22.7 to address gob vulnerability (GO-2024-3106) #99

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

JRocabruna
Copy link
Member

Description

This pull request adds the previously omitted changes necessary to fully address the encoding/gob vulnerability identified as GO-2024-3106. The initial update to Go 1.22.7 in PR #97 was incomplete. This PR ensures all required updates are applied to mitigate the vulnerability effectively.

Checklist

Please ensure the following guidelines are met:

  • The code follows the style guidelines of this project.
  • A self-review has been performed on the code.
  • The code is well-documented, and comments have been added where necessary.
  • Tests have been added to prove that the fix is effective or that the feature works. All existing tests pass.
  • Commit messages follow the convention type(scope): description.
  • The pull request has no conflicts with the base branch.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

This PR is a follow-up to PR #97, which partially addressed the gob vulnerability. The current changes ensure comprehensive mitigation of the issue.

@JRocabruna JRocabruna added bug Something isn't working security Issues related to improving security. dependencies Issues related to managing and updating project dependencies. labels Nov 15, 2024
@JRocabruna JRocabruna self-assigned this Nov 15, 2024
Copy link
Collaborator

@DarkRockMountain-admin DarkRockMountain-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

The update to Go 1.22.7 effectively addresses the encoding/gob vulnerability (GO-2024-3106). The changes are straightforward and necessary for maintaining the project's security.

Review Checklist

  • Code adheres to the project's coding guidelines.
  • Changes are well-documented.
  • Tests have been added/updated and pass successfully.
  • Commit messages follow the correct format: type(scope): description.
  • No conflicts with the base branch.

Approval

Approved: Changes look good and meet the project's contribution standards.

@DarkRockMountain-admin DarkRockMountain-admin merged commit 321b00d into develop Nov 15, 2024
6 of 7 checks passed
@DarkRockMountain-admin DarkRockMountain-admin deleted the fix/gob-vulnerability-go-1.22.7 branch November 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Issues related to managing and updating project dependencies. security Issues related to improving security.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SECURITY] - Update Go to 1.22.7 to Address encoding/gob Issue (GO-2024-3106)
2 participants