Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle underscore not being allowed in dns names #4109

Open
1 of 6 tasks
pbiggar opened this issue Jun 7, 2022 · 2 comments
Open
1 of 6 tasks

handle underscore not being allowed in dns names #4109

pbiggar opened this issue Jun 7, 2022 · 2 comments
Labels
later Let's think about this later -- we have some higher-priority things to work through first needs-review I plan on going through each of the issues and clarifying them -- this is to mark remaining issues

Comments

@pbiggar
Copy link
Member

pbiggar commented Jun 7, 2022

Trying to access domain names with underscores in the subdomain doesn't work with the .NET httpclient. It's marked as WONTFIX: dotnet/runtime#35880. There is a workaround but I'd rather not accrue the debt considering it's technically wrong.

This is a problem because some of our users have usernames with underscores. So when they access user_name.builtwithdark.com with our httpclient, there's an SSL error:

<ErrorRail: Error "The SSL connection could not be established, see inner exception. The remote certificate is invalid according to the validation procedure: RemoteCertificateNameMismatch">

The correct solution, according to the grand plan of dark that's in my head, is to not use usernames in subdomains. I'll write up an issue for that. In the meantime, we need to patch over this in a forward compatible way.

  • disallow underscores in usernames in the adduser canvas for signup
  • disallow in Accounts.fs when creating users (note the UserName.create regex will still need to support users with underscores so we can't change that)
  • tell users about the subdomain situation, offer to change their usernames
    • we would need to rename the user, the canvas, and the custom_domain hosts
    • update signup page
  • re-allow underscores when switch to darklang.io is complete
@pbiggar pbiggar changed the title disallow new usernames with underscores handle underscore not being allowed in dns names Jun 7, 2022
@pbiggar
Copy link
Member Author

pbiggar commented Jun 7, 2022

image

@StachuDotNet
Copy link
Member

StachuDotNet commented Jun 21, 2022

re-allow underscores when switch to darklang.io is complete

relevant issue: #3824.

@pbiggar pbiggar added this to the Great experience for solo dev milestone Oct 18, 2022
@StachuDotNet StachuDotNet removed this from the Great experience for solo dev milestone Jan 22, 2024
@StachuDotNet StachuDotNet added later Let's think about this later -- we have some higher-priority things to work through first needs-review I plan on going through each of the issues and clarifying them -- this is to mark remaining issues labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
later Let's think about this later -- we have some higher-priority things to work through first needs-review I plan on going through each of the issues and clarifying them -- this is to mark remaining issues
Projects
None yet
Development

No branches or pull requests

2 participants