Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap: Bundle multiple requests/blocks into a single message #210

Open
dariusc93 opened this issue May 10, 2024 · 0 comments
Open

bitswap: Bundle multiple requests/blocks into a single message #210

dariusc93 opened this issue May 10, 2024 · 0 comments
Labels
enhancement New feature or request p:high High Priority

Comments

@dariusc93
Copy link
Owner

In the internal implementation of bitswap, wants and haves were split into their own respective sessions on purpose to allow handling each request on its own, putting peers into those sessions based on any requests made for said blocks, however this would result in multiple messages being sent when multiple blocks are requested. We could optimize this by bundling the multiple requests into a single message, assuming we can stay below the max message size (which is 2MB). If a message does begin to reach that limit, we could split it up into multiple messages if needed.

@dariusc93 dariusc93 added the p:low Low Priority label May 10, 2024
@dariusc93 dariusc93 changed the title bitswap: Include multiple requests/blocks in a single message bitswap: Bundle multiple requests/blocks in a single message May 10, 2024
@dariusc93 dariusc93 changed the title bitswap: Bundle multiple requests/blocks in a single message bitswap: Bundle multiple requests/blocks into a single message May 10, 2024
@dariusc93 dariusc93 added p:high High Priority and removed p:low Low Priority labels Jul 4, 2024
@dariusc93 dariusc93 added the enhancement New feature or request label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p:high High Priority
Projects
None yet
Development

No branches or pull requests

1 participant