Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Errors #2

Open
dariusc93 opened this issue Aug 26, 2022 · 2 comments
Open

Implement Errors #2

dariusc93 opened this issue Aug 26, 2022 · 2 comments
Assignees
@dariusc93
Labels
p:high High Priority refactor

Comments

@dariusc93
Copy link
Owner

dariusc93 commented Aug 26, 2022 •
edited
Loading

Currently, errors are handled by anyhow, but it may be better to return specific error types utilizing thiserror and use anyhow for errors that does not yield a specific error (eg gossipsub builder returns &'static str as an error).
@dariusc93 dariusc93 added the p:low Low Priority label Dec 8, 2022
@matthiasbeyer
Copy link

I would be very interested in this being resolved. Right now, error handling with the rust-ipfs crate is very hard to almost impossible because it does not use proper error typing.

Tell me if you need help here!

@dariusc93
Copy link
Owner Author

dariusc93 commented Aug 3, 2023 •
edited
Loading

Hey @matthiasbeyer! I do agree that the error handling in this crate is not easy to work with and this is something I do plan on targeting extremely soon.

EDIT: Also to mention any and all contributions are welcomed

@dariusc93 dariusc93 added p:high High Priority refactor and removed p:low Low Priority labels Aug 3, 2023
@dariusc93 dariusc93 self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dariusc93 dariusc93

Labels
p:high High Priority refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthiasbeyer @dariusc93