Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCIO configs inconsistencies when using the command line flag #414

Open
Minkiu opened this issue Apr 1, 2021 · 1 comment
Open

OCIO configs inconsistencies when using the command line flag #414

Minkiu opened this issue Apr 1, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Minkiu
Copy link

Minkiu commented Apr 1, 2021

Hello there,

thanks for the great software, couldn't find an issue for this, so made one.

I found what appears to be a bug in the way that DJV handles configs, sometimes it duplicates them, sometimes it removes them... so here's how to reproduce the error.

First I add aces_1.1 inside the DJV directory /tmp/DJV-2.0.8-Linux/etc/Color/aces_1.1/config.ocio

Then, alternate between the following commands:
LD_LIBRARY_PATH=lib bin/djv -ocio_config /tmp/DJV-2.0.8-Linux/etc/Color/nuke-default/config.ocio -ocio_display default -ocio_view sRGB -ocio_image sRGB

and

LD_LIBRARY_PATH=lib bin/djv -ocio_config /tmp/DJV-2.0.8-Linux/etc/Color/aces_1.1/config.ocio -ocio_display ACES -ocio_image "ACES - ACES2065-1"

When going into the Image > Colorspace > Config setting, it changes in an inconsistent way, I think it might be following a pattern, but not really sure about it; the trouble starts when you try to load the nuke-default after having loaded the aces (so in the third command).

My expectation is that it loads the config I pass, if it doesn't exists add it otherwise laod the known one, and doesn't mess with the other ones.

I made a small video demonstrating the issue:
https://user-images.githubusercontent.com/1800151/113329796-ede90600-9315-11eb-85f4-a0c87fb930b0.mp4

Sample of the config when things are wrong (aces shows duplicated):

"djv::UI::Settings::ColorSpace": {
        "Configs": [
            {
                "Display": "sRGB", 
                "FileColorSpaces": {
                    "": "", 
                    "OpenEXR": "lnh"
                }, 
                "FileName": "/tmp/DJV-2.0.8-Linux/etc/Color/spi-anim/config.ocio", 
                "Name": "spi-anim", 
                "View": "Film"
            }, 
            {
                "Display": "sRGB", 
                "FileColorSpaces": {
                    "": "", 
                    "Cineon": "lg10", 
                    "DPX": "lg10", 
                    "OpenEXR": "lnh"
                }, 
                "FileName": "/tmp/DJV-2.0.8-Linux/etc/Color/spi-vfx/config.ocio", 
                "Name": "spi-vfx", 
                "View": "Film"
            }, 
            {
                "Display": "ACES", 
                "FileColorSpaces": {
                    "": "ACES - ACES2065-1"
                }, 
                "FileName": "/tmp/DJV-2.0.8-Linux/etc/Color/nuke-default/config.ocio", 
                "Name": "nuke-default", 
                "View": "sRGB"
            }, 
            {
                "Display": "ACES", 
                "FileColorSpaces": {
                    "": "ACES - ACES2065-1"
                }, 
                "FileName": "/tmp/DJV-2.0.8-Linux/etc/Color/aces_1.1/config.ocio", 
                "Name": "aces_1.1", 
                "View": "sRGB"
            }
        ],

And I made Gist with the Log:
https://gist.github.com/Minkiu/981f4e39670a945a51b0c1c6488f0f1a

Might be related to: #409

Hope this helps,
Cheers!

@darbyjohnston
Copy link
Owner

Hi, sorry for the delay! Thanks for the detailed bug description, I'll try to recreate it and see if I can fix it for the next version.

@darbyjohnston darbyjohnston self-assigned this Apr 7, 2021
@darbyjohnston darbyjohnston added the bug Something isn't working label Apr 7, 2021
@darbyjohnston darbyjohnston added this to the 2.0.9 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants