Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Sidecar not found by js-sdk in several cases using final release of 3.3.0 #580

Closed
paulyuk opened this issue Mar 6, 2024 · 2 comments · Fixed by #581
Closed
Assignees
Labels
bug Something isn't working needs-team-attention P0

Comments

@paulyuk
Copy link
Contributor

paulyuk commented Mar 6, 2024

Repro as seen in quickstart steps and failing tests
dapr/quickstarts#998

simple repro:

dapr run --app-id order-processor --resources-path ../../../components/ --app-protocol grpc --dapr-grpc-port 3500 -- node index.js
ℹ️  Dapr sidecar is up and running.
ℹ️  Updating metadata for appPID: 65932
ℹ️  Updating metadata for app command: node index.js
✅  You're up and running! Both Dapr and your app logs will appear here.

== APP == 2024-03-06T18:22:57.243Z INFO [GRPCClient, GRPCClient] Opening connection to localhost:3500
== APP == 2024-03-06T18:22:57.248Z INFO [GRPCClient, GRPCClient] Awaiting Sidecar to be Started
== APP == Could not get config item, err:Error: DAPR_SIDECAR_COULD_NOT_BE_STARTED
@paulyuk
Copy link
Contributor Author

paulyuk commented Mar 6, 2024

@shubham1172 replied in another chat

It is due to this proto change dapr/dapr@4d4c8b9
Strangely the tests did not catch it (which is a repair item), but I will fix this in a few hours.

@paulyuk
Copy link
Contributor Author

paulyuk commented Mar 6, 2024

Verified!

✅  You're up and running! Both Dapr and your app logs will appear here.

== APP == 2024-03-06T21:15:20.250Z INFO [GRPCClient, GRPCClient] Opening connection to localhost:3500
== APP == Configuration for orderId1: {"key":"orderId1","value":"103","version":"","metadata":{}}
== APP == Configuration for orderId2: {"key":"orderId2","value":"104","version":"","metadata":{}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-team-attention P0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants