Fix Configuration GRPC calls not sending metadata #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlund101
force-pushed
the
fix-grpc-config-metadata
branch
from
5ed0bbe to
31d22f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
=======================================
Coverage 55.79% 55.79%
=======================================
Files 14 14
Lines 319 319
Branches 63 63
=======================================
Hits 178 178
Misses 124 124
Partials 17 17 ☔ View full report in Codecov by Sentry. |
shubham1172
suggested changes
Feb 10, 2024
Signed-off-by: Trevor Lund <[email protected]>
Signed-off-by: Trevor Lund <[email protected]>
tlund101
force-pushed
the
fix-grpc-config-metadata
branch
from
b71c012 to
2d0faf8
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When sending a request for Configurations from Azure App Config, the call would silently drop the metadata that was sent with it. This would cause keys to be returned only if they had no labels on them when specified.
Having some unrelated errors preventing my local tests from running, though I did validate the change with the app that created this issue. Let me know if I'm missing a spot that should also be updated, as I'm new to this codebase.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #570
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: