Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test http actortest #554

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Nov 27, 2023

Description

it fails due to the following log

== APP ==   ● http/actors › configuration › actor configuration endpoint should contain the correct parameters
== APP == 
== APP ==     expect(received).toBe(expected) // Object.is equality
== APP == 
== APP ==     Expected: 9
== APP ==     Received: 11
== APP == 
== APP ==       114 |       const config = JSON.parse(await res.text());
== APP ==       115 |
== APP ==     > 116 |       expect(config.entities.length).toBe(9);
== APP ==           |                                      ^
== APP ==       117 |       expect(config.actorIdleTimeout).toBe("1h");
== APP ==       118 |       expect(config.actorScanInterval).toBe("30s");
== APP ==       119 |       expect(config.drainOngoingCallTimeout).toBe("1m");
== APP == 
== APP ==       at test/e2e/http/actors.test.ts:116:38
== APP ==       at fulfilled (test/e2e/http/actors.test.ts:40:58)

This is because two actors were newly registered in pr #536. For more details could refer to this link .

Signed-off-by: MregXN <[email protected]>
@MregXN MregXN requested review from a team as code owners November 27, 2023 15:15
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d33c5a4) 100.00% compared to head (4b78d5a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #554   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6         6           
  Branches         1         1           
=========================================
  Hits             6         6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MregXN
Copy link
Member Author

MregXN commented Nov 28, 2023

refer to issue #7128 in dapr/dapr

@shubham1172 shubham1172 added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dapr:main with commit f661574 Nov 28, 2023
7 of 8 checks passed
@MregXN MregXN deleted the fix-e2e-http-actortest branch November 29, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants