Update _index.md #552
Merged
Update _index.md #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix how define dapr server to it can work directly when you copy Signed-off-by: Feyyaz Acet <[email protected]>
|
Hi, thanks for the PR, the code is self-explanatory there because of L104. |
thanks for explanition, to me it was more aboout to fix the sample as it was not working directly when you copy. |
|
Oh I just noticed the comma missing, thanks for pointing it out. |
shubham1172
reviewed
Nov 20, 2023
Signed-off-by: Shubham Sharma <[email protected]>
shubham1172
approved these changes
Nov 20, 2023
in fact, after pr I found too many issue like that, will fix all of them and raise new and more comprehensive pr next week hopefully. |
|
That would be awesome, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix how define dapr server to it can work directly when you copy
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: