ActorId accepts invalid IDs, causing issues when making Actor HTTP calls

[heunghingwan]

When constructing an actor using strings such as url, it will throw with app-id not found error. I don’t know whether it is an SDK or core error.

Steps to Reproduce the Problem

const actor = await builder.build(new ActorId(url))
actor.test() <- throw with app-id not found

[shubham1172]

So URLs should not be allowed as actor IDs because of the way actor APIs are written, reference: https://docs.dapr.io/reference/api/actors_api/#get-actor-reminder

For example, if actor ID is https://foo.bar, the below request will look like /actors/${actorType}/https://foo.bar/state/${key}

js-sdk/src/actors/client/ActorClient/ActorClientHTTP.ts

Line 50 in b063e10

const result = await this.client.execute(`/actors/${actorType}/${actorId.getId()}/state/${key}`);

What we should do is throw an error if the actor ID is not proper or potentially sanitize it, instead of simply accepting any string.

js-sdk/src/actors/ActorId.ts

Line 20 in b063e10

this.id = id;

[heunghingwan]

Does this mean it will work when using grpc protocol?

[XavierGeerinck]

Does this mean it will work when using grpc protocol?

It would, but gRPC is not supported on the runtime :)