Replacing callbacks #522
Closed
Replacing callbacks #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… grpc client Signed-off-by: SoTrx <[email protected]>
Signed-off-by: SoTrx <[email protected]>
Signed-off-by: SoTrx <[email protected]>
Signed-off-by: SoTrx <[email protected]> chore(project): Pretty-fix Signed-off-by: SoTrx <[email protected]> chore(project): Pretty-fix Signed-off-by: SoTrx <[email protected]> chore(project): Pretty-fix Signed-off-by: SoTrx <[email protected]> chore(project): Pretty-fix Signed-off-by: SoTrx <[email protected]> chore(project): Pretty-fix Signed-off-by: SoTrx <[email protected]> chore(project): Pretty-fix Signed-off-by: SoTrx <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 35.23% 35.46% +0.22%
==========================================
Files 90 90
Lines 10143 10117 -26
Branches 415 394 -21
==========================================
+ Hits 3574 3588 +14
+ Misses 6503 6463 -40
Partials 66 66
☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I replaced callbacks in the gRPC client implementation with their promise equivalent.
It uses promisify. I considered wrapping the client itself, but I couldn't do it in a truly type-safe way.
Issue reference
#483
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Ps: Sorry for the delay, I kind of forgot that this issue existed to be honest.