Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have gRPC over SSL by default and enforce it #301

Open
XavierGeerinck opened this issue Jun 14, 2022 · 3 comments
Open

Have gRPC over SSL by default and enforce it #301

XavierGeerinck opened this issue Jun 14, 2022 · 3 comments
Labels
enhancement New feature or request triaged/resolved

Comments

@XavierGeerinck
Copy link
Contributor

XavierGeerinck commented Jun 14, 2022

Describe the proposal

We should have best practices in the core of the SDK. People developing with it should have a speed-up in developer experience but also adhere to security practices.

gRPC in the ecosystem today always utilizes the createInsecure() method which creates an unencrypted channel and exposes channel credentials. (more: https://www.trendmicro.com/en_us/research/20/h/how-unsecure-grpc-implementations-can-compromise-apis.html)

We should switch to utilizing createSsl() for several reason, but the main ones being:

Extra info can be found here as well: wechaty/puppet-service#124 and https://github.com/wechaty/puppet-service/pull/159/files

@shubham1172 shubham1172 added the enhancement New feature or request label Jul 21, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Sep 19, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged/resolved
Projects
None yet
Development

No branches or pull requests

3 participants