Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given Metadata is ignored on Htttp Service invocation #744

Closed
tillganster opened this issue May 30, 2022 · 2 comments · Fixed by #770
Closed

Given Metadata is ignored on Htttp Service invocation #744

tillganster opened this issue May 30, 2022 · 2 comments · Fixed by #770
Assignees
Labels
kind/bug Something isn't working P1 triaged/resolved Items triaged and ready
Milestone

Comments

@tillganster
Copy link

Expected Behavior

When Http-Headers are give to method invokeMethod of class DaprClient these headers should be sent along with the request.

Actual Behavior

It seems that the metadata is ignored when sending request. In AbstractClient line 115 see. There the given matadata is ignored. In DaprClientHttp line 211 see there are added additional headers to the request, but they come from the HttpExtension object.

Steps to Reproduce the Problem

  • invoke a service over http while giving a Map<String,String> to the metadata parameter
  • the invoked service won't get these Headers
@tillganster tillganster added the kind/bug Something isn't working label May 30, 2022
@yaron2
Copy link
Member

yaron2 commented May 31, 2022

Thanks for reporting. FYI, in general we encourage users to use a native HTTP client for service invocation calls and not use InvokeMethod.

@mukundansundar mukundansundar added this to the v1.6 milestone Jun 9, 2022
@mukundansundar mukundansundar added triaged/resolved Items triaged and ready P1 labels Jun 9, 2022
@artursouza artursouza modified the milestones: v1.6, v1.7 Jun 23, 2022
@pravinpushkar
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working P1 triaged/resolved Items triaged and ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants