Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hashicorp Vault from Secret Store example #667

Closed
artursouza opened this issue Dec 9, 2021 · 1 comment · Fixed by #719
Closed

Remove Hashicorp Vault from Secret Store example #667

artursouza opened this issue Dec 9, 2021 · 1 comment · Fixed by #719
Assignees
Labels
Milestone

Comments

@artursouza
Copy link
Member

artursouza commented Dec 9, 2021

Describe the proposal

There was a change in Hashicorp Vault output that broke the example validation. Instead, use the local file secret store so there is no need to install Hashicorp Vault anymore.

This work needs to make sure the instructions in the README.md file for the example is reworded to explain how the secret is retrieved. In addition, it should point to the documentation in Dapr docs website where other secret store components can be used.

Change should also remove Vault installation from the validate.yaml workflow file.

@fackee
Copy link
Contributor

fackee commented Jan 26, 2022

/assign

@mukundansundar mukundansundar added this to the v1.5 milestone Jan 26, 2022
@mukundansundar mukundansundar modified the milestones: v1.5, v1.6 Mar 22, 2022
@fackee fackee mentioned this issue Mar 30, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants