Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate RocketMQ Increased goroutine Count #4152

Closed
halspang opened this issue Jan 21, 2022 · 10 comments · Fixed by #4675
Closed

Investigate RocketMQ Increased goroutine Count #4152

halspang opened this issue Jan 21, 2022 · 10 comments · Fixed by #4675
Assignees
Labels
Milestone

Comments

@halspang
Copy link
Contributor

RocketMQ had to be removed from the 1.6 release because importing caused an increase of ~30 goroutines. This was seen as too large an increase and should be investigated before we can include it in the dapr runtime.

image

@halspang
Copy link
Contributor Author

@x-shadow-man, I saw you added RocketMQ, would you be a good person to investigate this as well?

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale Issues and PRs without response label Mar 22, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@yaron2 yaron2 reopened this Mar 29, 2022
@yaron2
Copy link
Member

yaron2 commented Mar 29, 2022

@shubham1172 did you end up taking a look at this?

@artursouza artursouza added pinned and removed stale Issues and PRs without response labels Mar 29, 2022
@shubham1172
Copy link
Member

No @yaron2, but I can track this going forward. Well, this looks like the root cause apache/rocketmq-client-go#678

@shubham1172
Copy link
Member

/assign

@shubham1172
Copy link
Member

This issue has been fixed with the latest prelease by apache/rocketmq-client-go#678. Here is a small example, the latest version does not cause any jump in go-routines.

Baseline

package main

import (
	"fmt"
	"runtime"
)

func main() {
	fmt.Printf("Number of goroutines: %d", runtime.NumGoroutine())
}
Number of goroutines: 1

RocketMQ v2.1.0

go get github.com/apache/rocketmq-client-go/v2@v2.1.0
package main

import (
	"fmt"
	"runtime"

	mqc "github.com/apache/rocketmq-client-go/v2/consumer"
)

func main() {
	_ = make(map[string]mqc.MessageSelector)
	fmt.Printf("Number of goroutines: %d", runtime.NumGoroutine())
}
Number of goroutines: 31

RocketMQ v2.1.1-rc2

go get github.com/apache/rocketmq-client-go/v2@v2.1.1-rc2

Same code as above.

Number of goroutines: 1

However, the latest version is still a pre-release - v2.1.1-rc2. Given that our Rocket MQ component will be alpha, it might be okay to use this (/cc @halspang). What do the maintainers think?

@yaron2
Copy link
Member

yaron2 commented Apr 6, 2022

Let's bring this back in 1.8.

@yaron2
Copy link
Member

yaron2 commented May 26, 2022

Closed via dapr/components-contrib#1740.

@yaron2 yaron2 closed this as completed May 26, 2022
@yaron2 yaron2 reopened this May 26, 2022
@yaron2
Copy link
Member

yaron2 commented May 26, 2022

Reopening as not in daprd yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants