From d08a1d7fe5339b2cc7f44d1a57eb6424dbac79bf Mon Sep 17 00:00:00 2001 From: Jeff Olivier Date: Fri, 2 Feb 2024 09:47:29 -0700 Subject: [PATCH] DAOS-623 ci: Use owners teams for CODEOWNERS (#13721) Added a few teams for different areas of the code. Signed-off-by: Jeff Olivier --- .github/CODEOWNERS | 43 ++++++++++++++++++++++---------- .github/pull_request_template.md | 2 +- 2 files changed, 31 insertions(+), 14 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b0662c11a41..e37f56a2ad8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,22 +4,25 @@ # or updates packaging in any way utils/rpms @daos-stack/build-and-release-watchers +src/gurt @daos-stack/common-watchers +src/common @daos-stack/common-watchers + # any PR that touches Go files should get a review from go-owners -*.go @daos-stack/go-watchers +*.go @daos-stack/go-owners @daos-stack/go-watchers # Notify vos-watcher of files touched affecting VOS -src/vos/ @daos-stack/vos-watchers -src/common/btree*.* @daos-stack/vos-watchers -src/include/daos/btree*.* @daos-stack/vos-watchers -src/include/daos_srv/vos*.* @daos-stack/vos-watchers -src/include/daos_srv/evtree.h @daos-stack/vos-watchers +src/vos/ @daos-stack/vos-owners @daos-stack/vos-watchers +src/common/btree*.* @daos-stack/vos-owners @daos-stack/vos-watchers +src/include/daos/btree*.* @daos-stack/vos-owners @daos-stack/vos-watchers +src/include/daos_srv/vos*.* @daos-stack/vos-owners @daos-stack/vos-watchers +src/include/daos_srv/evtree.h @daos-stack/vos-owners @daos-stack/vos-watchers # Jenkinsfile changes should be reviewed by Release Engineering Jenkinsfile @daos-stack/build-and-release-watchers # any PR that touches client API or high level client code -src/client @daos-stack/client-api-watchers -src/include/daos_*.* @daos-stack/client-api-watchers +src/client @daos-stack/client-api-owners @daos-stack/client-api-watchers +src/include/daos_*.* @daos-stack/client-api-owners @daos-stack/client-api-watchers # doc-watchers: files affecting documentation (docs, doxygen, etc.) mkdocs.yml @daos-stack/doc-watchers @@ -29,14 +32,28 @@ docs/ @daos-stack/doc-watchers *.md @daos-stack/doc-watchers # dev-build-watchers: Files affecting local builds (e.g. SCons) -SConstruct @daos-stack/dev-build-watchers -SConscript @daos-stack/dev-build-watchers -site_scons/ @daos-stack/dev-build-watchers -utils/sl @daos-stack/dev-build-watchers +SConstruct @daos-stack/dev-build-owners @daos-stack/dev-build-watchers +SConscript @daos-stack/dev-build-owners @daos-stack/dev-build-watchers +site_scons/ @daos-stack/dev-build-owners @daos-stack/dev-build-watchers +utils/sl @daos-stack/dev-build-owners @daos-stack/dev-build-watchers # ftest-watchers: files affecting functional tests -src/tests/ftest @daos-stack/ftest-watchers +src/tests/ftest @daos-stack/ftest-owners @daos-stack/ftest-watchers # telem-watchers: Changes related to the telemetry library src/utils/daos_metrics @daos-stack/telem-watchers src/gurt/telemetry.c @daos-stack/telem-watchers + +# PRs that touch the object layer +src/object/ @daos-stack/object-owners @daos-stack/object-watchers +src/rebuild/ @daos-stack/object-owners @daos-stack/object-watchers +src/dtx/ @daos-stack/object-owners @daos-stack/object-watchers + +# PRs that touch the CaRT layer +src/cart/ @daos-stack/cart-owners @daos-stack/cart-watchers + +# PRs that touch the metadata +src/pool/ @daos-stack/metadata-owners @daos-stack/metadata-watchers +src/container/ @daos-stack/metadata-owners @daos-stack/metadata-watchers +src/rdb/ @daos-stack/metadata-owners @daos-stack/metadata-watchers +src/rsvc/ @daos-stack/metadata-owners @daos-stack/metadata-watchers diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 20c4a7f5dd4..77cb0ed4fce 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,7 +9,7 @@ ### Gatekeeper: * [ ] You are the appropriate gatekeeper to be landing the patch. -* [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers. +* [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners. * [ ] Githooks were used. If not, request that user install them and check copyright dates. * [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs. * [ ] All builds have passed. Check non-required builds for any new compiler warnings.