Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for wagtail and some small issues. #2

Open
itekhi opened this issue Aug 8, 2020 · 0 comments
Open

Support for wagtail and some small issues. #2

itekhi opened this issue Aug 8, 2020 · 0 comments

Comments

@itekhi
Copy link

itekhi commented Aug 8, 2020

Hello, @dantium! Could you please make your module working with Wagtail? Please, I love it, in Django it works perfectly without an issue! But in Wagtail there are some issues with JS, for example when you click on span(add favicon) nothing happens. (If I manually add show class to model, all of the model buttons works just fine, which is weird, only when you select any of the icon it shows that it cannot get val of undefined, of course.)
I cant determine why only $('.faicon-add').on('click', function(){ won't work...
image
And you add jquery to the admin. Wagtail already uses jquery, so I think you need to check somehow if admin is Wagtail's admin and then whether or not load jquery.

And some issues with CSS in the model, of course because of Wagtail's css.
image
Other than that, everything works perfectly, only yaml was showing a warning \site-packages\faicon\models.py:23: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
I then changed yaml.load(stream) on line 23 to yaml.safe_load(stream) and there was no warning anymore.

And when you already have some objects in the database and want to edit it when there is no icon in the database in that object, wagtail shows an error.
image

Actually I was searching a lot for working django module for Font Awesome, and your is the best one!
And that's all I found while using it. Please, fix it. I will use it in all of my projects 100%! 😄 If you don't have time to work on that project, I can make a pull request, I think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant