You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, @dantium! Could you please make your module working with Wagtail? Please, I love it, in Django it works perfectly without an issue! But in Wagtail there are some issues with JS, for example when you click on span(add favicon) nothing happens. (If I manually add show class to model, all of the model buttons works just fine, which is weird, only when you select any of the icon it shows that it cannot get val of undefined, of course.)
I cant determine why only $('.faicon-add').on('click', function(){ won't work...
And you add jquery to the admin. Wagtail already uses jquery, so I think you need to check somehow if admin is Wagtail's admin and then whether or not load jquery.
And some issues with CSS in the model, of course because of Wagtail's css.
Other than that, everything works perfectly, only yaml was showing a warning \site-packages\faicon\models.py:23: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
I then changed yaml.load(stream) on line 23 to yaml.safe_load(stream) and there was no warning anymore.
And when you already have some objects in the database and want to edit it when there is no icon in the database in that object, wagtail shows an error.
Actually I was searching a lot for working django module for Font Awesome, and your is the best one!
And that's all I found while using it. Please, fix it. I will use it in all of my projects 100%! 😄 If you don't have time to work on that project, I can make a pull request, I think...
The text was updated successfully, but these errors were encountered:
Hello, @dantium! Could you please make your module working with Wagtail? Please, I love it, in Django it works perfectly without an issue! But in Wagtail there are some issues with JS, for example when you click on
span
(add favicon) nothing happens. (If I manually addshow
class to model, all of the model buttons works just fine, which is weird, only when you select any of the icon it shows that it cannot getval
of undefined, of course.)I cant determine why only
$('.faicon-add').on('click', function(){
won't work...And you add jquery to the admin. Wagtail already uses jquery, so I think you need to check somehow if admin is Wagtail's admin and then whether or not load jquery.
And some issues with CSS in the model, of course because of Wagtail's css.
Other than that, everything works perfectly, only yaml was showing a warning
\site-packages\faicon\models.py:23: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
I then changed
yaml.load(stream)
on line 23 toyaml.safe_load(stream)
and there was no warning anymore.And when you already have some objects in the database and want to edit it when there is no icon in the database in that object, wagtail shows an error.
Actually I was searching a lot for working django module for Font Awesome, and your is the best one!
And that's all I found while using it. Please, fix it. I will use it in all of my projects 100%! 😄 If you don't have time to work on that project, I can make a pull request, I think...
The text was updated successfully, but these errors were encountered: