DDFBRA-234-test-search #88
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobArrow
force-pushed
the
DDFBRA-234-test-search
branch
from
d7f13e7 to
55e27f0
Compare
The generated files does not contain any jsx, but does contain React hooks, which according to the docs, should use a file extension of either `.js` or `.ts`
As we want more typesafety of our named operations, we can use this plugin to generate an object containing all operation names at the end of our generated graphql schema
By creating a union type of available operation name, we can create a custom cypress commands which is strongly typed.
Im aware that materialTypeGeneral.code gives type errors because it is not used as an enum. Need to find a good solution for this.
Everything doesn't have to be a factory. This proves that we can mix factories with regular fixtures inside tests.
The codegen got updates, and we need to account for some additional fields in the response
We need to find a different way to catch error from pubhub, as the endpoint will return `400 Bad Request` even though a valid response is returned as `{"code":128,"message":"Bogen er ikke tilgængelig for udlån (#128)."}`. This response should not break the application.
JacobArrow
force-pushed
the
DDFBRA-234-test-search
branch
from
49b2e19 to
da35c59
Compare
…get hydration errors
… my fine grained factory usage inside tests
…d audiobook works
JacobArrow
force-pushed
the
DDFBRA-234-test-search
branch
from
6c5355f to
675b523
Compare
…is a valid url. We can provide pr env to get access to CMS data
…age is currently not available until we have mocked the data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
Please add a link to the issue being addressed by this change.
Description
Please include a short description of the suggested change and the reasoning behind the approach you have chosen.
Screenshot of the result
If your change affects the user interface you should include a screenshot of the result with the pull request.
Additional comments or questions
If you have any further comments or questions for the reviewer them please add them here.