improve package bundling #84
Conversation
e-cloud
force-pushed
the
feature/bundle-tool
branch
2 times, most recently
from
d280d26 to
4d05c12
Compare
Breacking change: here we flatten one folder with app folder removed, if someone used to use the code or types from source, you have to adapt the path.
previously, ngx-pipes uses a simple bundle tool chain to publish no-clean-enough package, it raises some resolve conflicts with angular-cli and latest angular<Angular v5>. Here we apply the ng-packagr to generate the bundles following the [Angular package format](https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/edit). With that, the output could be easily consume by various module loader. Breaking Change: we do not publish the source file of each pipe now. As with webpack/rollup's treeshaking feature, we don't need to publish pipes separately. User who used to reference to source pipes directly should update their paths.
e-cloud
force-pushed
the
feature/bundle-tool
branch
from
4d05c12 to
2ae45cc
Compare
package.json
Outdated
| "standard-version": "^4.2.0", | ||
| "ts-node": "^3.0.0", | ||
| "tslint": "^5.5.0", | ||
| "typescript": "~2.5.0", |
There was a problem hiding this comment.
Lets upgrade this to the latest 2.6.1
There was a problem hiding this comment.
@danrevah I'm sorry, i forgot to fix this version. we'd better not upgrade the typescript bigger than 2.4. Because Angular doesn't support it now. I've tried to upgrade to v2.5 in another package, with rollup, it produces incorrect output. So, upgrading typescript is not proposed.
There was a problem hiding this comment.
you have to downgrade it, like typescript: ~2.4.0
There was a problem hiding this comment.
It's 2.4.0 in the merge, and this commit has been merged and released in version v2.0.0.
Thanks!
|
That was a really great work. Thank you for your help in improving this library! |
|
this commit has ruined the AOT compilation #86 .. I will try to investigate, do you have any leads? |
|
Ok this was a really easy fix, I saw that the metadata files are not being generated properly. For reference this is the commit that should fix it: |
|
@danrevah sorry for that bug, glad you have fixed it. |
previously, ngx-pipes uses a simple bundle tool chain to publish no-clean-enough package, it raises some resolve conflicts with angular-cli and latest angular. Here we apply the ng-packagr to generate the bundles following the Angular package format. With that, the output could be easily consume by various module loader.
Breaking Change:
The PR should only be merged after PR #83.