From 0169dd86c6297f03bc26f521ded89a4f607f770b Mon Sep 17 00:00:00 2001
From: Dannon Baker <dannon.baker@gmail.com>
Date: Mon, 23 Oct 2023 14:04:21 -0400
Subject: [PATCH] Fix vue set+del when imported explicitly.

---
 client/src/components/Form/FormInputs.vue      |  4 +---
 client/src/stores/collectionAttributesStore.ts |  8 ++++----
 client/src/stores/collectionElementsStore.ts   | 16 ++++++++--------
 client/src/stores/workflowStore.ts             |  4 ++--
 4 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/client/src/components/Form/FormInputs.vue b/client/src/components/Form/FormInputs.vue
index 0a29d2ba9f4e..ab666ad69236 100644
--- a/client/src/components/Form/FormInputs.vue
+++ b/client/src/components/Form/FormInputs.vue
@@ -65,8 +65,6 @@
 </template>
 
 <script>
-import { set } from "vue";
-
 import { matchCase } from "@/components/Form/utilities";
 
 import FormCard from "./FormCard.vue";
@@ -147,7 +145,7 @@ export default {
         repeatInsert(input) {
             const newInputs = structuredClone(input.inputs);
 
-            set(input, "cache", input.cache ?? []);
+            input.cache = input.cache ?? [];
             input.cache.push(newInputs);
 
             this.onChangeForm();
diff --git a/client/src/stores/collectionAttributesStore.ts b/client/src/stores/collectionAttributesStore.ts
index 96b31d0c03da..33de5923eb06 100644
--- a/client/src/stores/collectionAttributesStore.ts
+++ b/client/src/stores/collectionAttributesStore.ts
@@ -1,5 +1,5 @@
 import { defineStore } from "pinia";
-import { computed, del, ref, set } from "vue";
+import { computed, ref } from "vue";
 
 import { DatasetCollectionAttributes } from "./services";
 import { fetchCollectionAttributes } from "./services/datasetCollection.service";
@@ -25,13 +25,13 @@ export const useCollectionAttributesStore = defineStore("collectionAttributesSto
     });
 
     async function fetchAttributes(params: { hdcaId: string }) {
-        set(loadingAttributes.value, params.hdcaId, true);
+        loadingAttributes.value[params.hdcaId] = true;
         try {
             const attributes = await fetchCollectionAttributes(params);
-            set(storedAttributes.value, params.hdcaId, attributes);
+            storedAttributes.value[params.hdcaId] = attributes;
             return attributes;
         } finally {
-            del(loadingAttributes.value, params.hdcaId);
+            delete loadingAttributes.value[params.hdcaId];
         }
     }
 
diff --git a/client/src/stores/collectionElementsStore.ts b/client/src/stores/collectionElementsStore.ts
index 8f97ad319745..59794696ce52 100644
--- a/client/src/stores/collectionElementsStore.ts
+++ b/client/src/stores/collectionElementsStore.ts
@@ -1,5 +1,5 @@
 import { defineStore } from "pinia";
-import { computed, del, ref, set } from "vue";
+import { computed, ref } from "vue";
 
 import { CollectionEntry, DCESummary, HDCASummary, HistoryContentItemBase, isHDCA } from "./services";
 import { fetchCollectionDetails, fetchElementsFromCollection } from "./services/datasetCollection.service";
@@ -79,7 +79,7 @@ export const useCollectionElementsStore = defineStore("collectionElementsStore",
             // Adjust the offset to the first missing element
             params.offset += firstMissingIndexInRange;
 
-            set(loadingCollectionElements.value, collectionKey, true);
+            loadingCollectionElements.value[collectionKey] = true;
             // Mark all elements in the range as fetching
             params.storedElements
                 .slice(params.offset, params.offset + params.limit)
@@ -91,15 +91,15 @@ export const useCollectionElementsStore = defineStore("collectionElementsStore",
             });
             // Update only the elements that were fetched
             params.storedElements.splice(params.offset, fetchedElements.length, ...fetchedElements);
-            set(storedCollectionElements.value, collectionKey, params.storedElements);
+            storedCollectionElements.value[collectionKey] = params.storedElements;
         } finally {
-            del(loadingCollectionElements.value, collectionKey);
+            delete loadingCollectionElements.value[collectionKey];
         }
     }
 
     async function loadCollectionElements(collection: CollectionEntry) {
         const elements = await fetchElementsFromCollection({ entry: collection });
-        set(storedCollectionElements.value, getCollectionKey(collection), elements);
+        storedCollectionElements.value[getCollectionKey(collection)] = elements;
     }
 
     function saveCollections(historyContentsPayload: HistoryContentItemBase[]) {
@@ -120,13 +120,13 @@ export const useCollectionElementsStore = defineStore("collectionElementsStore",
     }
 
     async function fetchCollection(params: { id: string }) {
-        set(loadingCollectionElements.value, params.id, true);
+        loadingCollectionElements.value[params.id] = true;
         try {
             const collection = await fetchCollectionDetails({ hdcaId: params.id });
-            set(storedCollections.value, collection.id, collection);
+            storedCollections.value[collection.id] = collection;
             return collection;
         } finally {
-            del(loadingCollectionElements.value, params.id);
+            delete loadingCollectionElements.value[params.id];
         }
     }
 
diff --git a/client/src/stores/workflowStore.ts b/client/src/stores/workflowStore.ts
index aca2e887f5e7..7ca593b4bdc8 100644
--- a/client/src/stores/workflowStore.ts
+++ b/client/src/stores/workflowStore.ts
@@ -1,6 +1,6 @@
 import axios from "axios";
 import { defineStore } from "pinia";
-import { computed, ref, set } from "vue";
+import { computed, ref } from "vue";
 
 import { getAppRoot } from "@/onload/loadConfig";
 import type { Steps } from "@/stores/workflowStepStore";
@@ -58,7 +58,7 @@ export const useWorkflowStore = defineStore("workflowStore", () => {
 
             const { data } = await promise;
 
-            set(workflowsByInstanceId.value, workflowId, data as Workflow);
+            workflowsByInstanceId.value[workflowId] = data as Workflow;
         }
 
         workflowDetailPromises.delete(workflowId);