Return a promise on stream finish to improve async handling in playStream function #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
playStream
in a playlist loop, thevStream.once("finish")
callback in its current implementation does not provide a mechanism to await the completion of a video before proceeding to the next one. As a result, all videos in the playlist attempt to play simultaneously.src/media/newApi.ts
: Added a promise to theplayStream
function that resolves when the stream finishes.Usage example: