New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(onesignal): documentation doesn't match method #1710

Closed

janpio opened this issue Jun 20, 2017 · 5 comments

Labels

Contributor

janpio commented Jun 20, 2017

https://github.com/ionic-team/ionic-native/blob/master/src/@ionic-native/plugins/onesignal/index.ts#L582

documentation has parameter, method doesn't.

ihadeed added the improve docs label

AntonioMenti commented Jun 20, 2017 •

edited

Loading

See https://forum.ionicframework.com/t/one-signal-problem/94981/17

The documentation present here

https://ionicframework.com/docs/native/onesignal/

describe unreleased method getPermissionSubscriptionState

Contributor

neoassyrian commented Jun 29, 2017

Should be resolved with this PR #1742

rafbgarcia commented Oct 21, 2017

So this should be resolved, right?

Contributor

neoassyrian commented Oct 24, 2017

I believe so

Contributor Author

janpio commented Oct 24, 2017

I made the mistake of linking to master instead of to a commit - so I can't check what I was talking about back then. Shame.

janpio closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment