Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn for external dependencies #199

Open
pi0 opened this issue Dec 6, 2020 · 1 comment
Open

feat: warn for external dependencies #199

pi0 opened this issue Dec 6, 2020 · 1 comment
Assignees
@danielroe
Labels
enhancement New feature or request

Comments

@pi0
Copy link

pi0 commented Dec 6, 2020

🆒 Your use case

Being aware if a dependency is missing and being inlined

🆕 The solution you'd like

Have console warning about externals and a config to mark them as externals instead of silently inlining
@pi0 pi0 added the enhancement New feature or request label Dec 6, 2020
@pi0
Copy link
Author

pi0 commented Jun 23, 2021

Silently inlining dependencies is becoming critical which I think worth trying to bring from unbuild (https://github.com/unjs/unbuild/blob/5004f8077995075c7e547a69ad3d89cc577cad3f/src/builder/rollup.ts#L105) (last time happened on nuxt image module)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pi0 @danielroe