Fix callbacks for channel 0 #159
Conversation
Events can be fired for entities and channels, so we also need to register callbacks for the HMChannel instance - even on channel 0. This fixes the updating of the `UNREACH` flag, which until now is only updated when reloading pyhomematic. See danielperna84/pyhomematic#121
|
Thanks. It's been a while since I worked on this topic, so I'm unsure if this has possible sideffects. I'll just assume you have tested this thoroughly and everything keeps working for you as it used to. 😉 |
|
Could you please recreate the PR? You had it pointing to the master branch, not the dev branch, and I merged it without checking. Hence I reverted the merge to keep the master branch in sync with the last release. |
|
@danielperna84 Sorry about the wrong branch. I assumed that the master branch is for "mainline" development and "dev" is your personal branch. Since you have created a PR template now this is clear :) I have just created a new PR (see #161). Yes, I have tested this in my environment (CCU2) and it did not have any side effects. The |
Events can be fired for entities and channels, so we also need to
register callbacks for the HMChannel instance - even on channel 0.
This fixes the updating of the
UNREACHflag, which until now isonly updated when reloading pyhomematic.
See danielperna84/pyhomematic#121